Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(invalid) Testing ESLint Action #938

Closed
wants to merge 8 commits into from
Closed

(invalid) Testing ESLint Action #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dfbb1c3
(invalid) Testing ESLint Action
ghys Mar 7, 2021
c8a83f1
Add format json to ESLint action command
ghys Mar 7, 2021
9c01ab9
Revert to stylish with no color
ghys Mar 7, 2021
972d541
revert to npm i
ghys Mar 7, 2021
0de88c1
Try compact format
ghys Mar 7, 2021
7ee1fb7
Activate debug
ghys Mar 7, 2021
f5c53dd
Change ESLint args
ghys Mar 7, 2021
337bb19
Remove format
ghys Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/mainui-eslint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ jobs:
${{ runner.os }}-

- name: Install Dependencies
run: npm install
if: steps.cache.outputs.cache-hit != 'true'
run: npm i

- name: Run ESLint
run: npx eslint src/**/*.js src/**/*.vue
run: npx eslint --ext js --ext vue src
11 changes: 6 additions & 5 deletions bundles/org.openhab.ui/web/src/components/cards/location-card.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<template>
<model-card type="location" :context="context" :element="element" header-height="200px">
<template v-slot:glance>
<model-card type="location" :context="context" :element="element" header-height="200px" >
<template
v-slot:glance>
<div v-if="!subtitle && parentLocation" class="subtitle"><small>{{parentLocation}}</small></div>
<div v-if="context && context.component.slots && context.component.slots.glance" class="display-flex flex-direction-column align-items-flex-start">
<generic-widget-component :context="childContext(slotComponent)" v-for="(slotComponent, idx) in context.component.slots.glance" :key="'glance-' + idx" @command="onCommand" />
Expand Down Expand Up @@ -69,8 +70,8 @@ export default {
computed: {
propertiesListContext () {
return {
store: this.$store.getters.trackedItems,
component: {
store: this.$store.getters.trackedItems,
component: {
component: 'oh-list',
config: {
mediaList: true
Expand Down Expand Up @@ -101,7 +102,7 @@ export default {
component: {
component: 'oh-list',
config: {
mediaList: true
mediaList: true,
},
slots: {
default: [...standaloneEquipment, ...equipmentWithPoints].flat()
Expand Down