-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thing details: Make link in Thing status description clickable #2996
Conversation
todo: modify the link format in jellyfin's CONFIGURATION_PENDING description so it would be picked up by this |
Signed-off-by: Jimmy Tanagra <[email protected]>
d497c6b
to
d3b8fda
Compare
#2670 Bundle Size — 10.98MiB (+0.04%).d3b8fda(current) vs a9954c3 main#2668(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2670 |
Baseline #2668 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 18.28% |
17.39% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2950 |
2950 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% (+1.12% ) |
1.78% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2670 |
Baseline #2668 |
|
---|---|---|
JS | 9.19MiB (+0.04% ) |
9.19MiB |
CSS | 867.02KiB |
867.02KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch jimtng:thing-desc-url-linker Project dashboard
Generated by RelativeCI Documentation Report issue
There is something similar in Netatmo binding also. The idea is great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Can you please update the binding developer docs?
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
Thanks for the pointer! I found it in Netatmo and submitted a PR to make it work. So now there are 4 bindings that I know of. |
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
See openhab/openhab-webui#2996 Signed-off-by: Jimmy Tanagra <[email protected]>
Resolve #2994