Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing details: Make link in Thing status description clickable #2996

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 9, 2025

Resolve #2994

@jimtng
Copy link
Contributor Author

jimtng commented Jan 9, 2025

todo: modify the link format in jellyfin's CONFIGURATION_PENDING description so it would be picked up by this

@jimtng jimtng force-pushed the thing-desc-url-linker branch from d497c6b to d3b8fda Compare January 9, 2025 10:53
Copy link

relativeci bot commented Jan 9, 2025

#2670 Bundle Size — 10.98MiB (+0.04%).

d3b8fda(current) vs a9954c3 main#2668(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#2670
     Baseline
#2668
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.28% 17.39%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
Change  Duplicate Code 1.8%(+1.12%) 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2670
     Baseline
#2668
Regression  JS 9.19MiB (+0.04%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:thing-desc-url-linkerProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng jimtng changed the title Thing status: Make link in Thing status description clickable Thing details: Make link in Thing status description clickable Jan 9, 2025
@clinique
Copy link

clinique commented Jan 9, 2025

There is something similar in Netatmo binding also. The idea is great.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you please update the binding developer docs?

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 9, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 9, 2025
@florian-h05 florian-h05 merged commit d16fe3a into openhab:main Jan 9, 2025
5 checks passed
jimtng added a commit to jimtng/openhab-addons that referenced this pull request Jan 10, 2025
jimtng added a commit to jimtng/openhab-addons that referenced this pull request Jan 10, 2025
@jimtng jimtng deleted the thing-desc-url-linker branch January 10, 2025 01:04
@jimtng
Copy link
Contributor Author

jimtng commented Jan 10, 2025

There is something similar in Netatmo binding also. The idea is great.

Thanks for the pointer! I found it in Netatmo and submitted a PR to make it work. So now there are 4 bindings that I know of.

jimtng added a commit to jimtng/openhab-addons that referenced this pull request Jan 10, 2025
jimtng added a commit to jimtng/openhab-docs that referenced this pull request Jan 10, 2025
jimtng added a commit to jimtng/openhab-docs that referenced this pull request Jan 10, 2025
jimtng added a commit to jimtng/openhab-docs that referenced this pull request Jan 10, 2025
jimtng added a commit to jimtng/openhab-docs that referenced this pull request Jan 10, 2025
jlaur pushed a commit to openhab/openhab-addons that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linkify Thing configuration links in the Thing status
3 participants