Link add/edit: Fix profile selection #2941
Conversation
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
|
Supersedes #2936. |
#2592 Bundle Size — 10.9MiB (~+0.01%).bb2c72b(current) vs 3861fa8 main#2591(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2592 |
Baseline #2591 |
|
|---|---|---|
 Initial JS |
1.9MiB |
1.9MiB |
| Initial CSS |
577.39KiB |
577.39KiB |
| Cache Invalidation |
18.15% |
18.15% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
 Modules |
2947(+0.03%) |
2946 |
| Duplicate Modules |
154 |
154 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #2592 |
Baseline #2591 |
|
|---|---|---|
| JS |
9.11MiB (~+0.01%) |
9.11MiB |
| CSS |
866.47KiB |
866.47KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:link-profiles Project dashboard
Generated by RelativeCI Documentation Report issue
|
Wrt to #2936 (comment): I have tested this and it still works 👍 |
|
@jimtng Can you please test this PR? |
bundles/org.openhab.ui/web/src/pages/settings/things/link/link-mixin.js
Outdated
Show resolved
Hide resolved
It seems to work fine, but I'm not the one who's affected by this, so I can't say with 100% certainty. Could you build a jar and ask the people here to test: https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987 |
Signed-off-by: Florian Hotze <[email protected]>
Regression from #2690. Reported here: https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987 When creating a Thing channel link to an item, the profile selection are disabled. This presents two problems: - It made linking a trigger channel to an item not possible, because a profile must be selected, but they're disabled. - Linking a non-trigger channel to a new item is possible, but selecting a profile is not possible at link creation. The user has to create the link without a profile first, then go back to edit the link in order to assign a profile. When editing a channel link, profile selection was possible for unsupported profiles, e.g. when editing a link between a Switch Item and a Number channel, one could edit the link to use the default or follow profiles. --------- Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit bd9c6f0)
florian-h05
added
the
patch
|
Merged as it has been confirmed in the linked community thread that the fix works. |
|
I would classify this as critical as this makes the profile selections not useable at all. (together with #2690 ) |
Regression from #2690.
Reported here:
https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987
When creating a Thing channel link to an item, the profile selection are disabled. This presents two problems:
When editing a channel link, profile selection was possible for unsupported profiles, e.g. when editing a link between a Switch Item and a Number channel, one could edit the link to use the default or follow profiles.
This PR fixes these problems.
Note this needs to be backported to 4.3.x