Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget expressions: Fix screen object not properly initialized & updated #2933

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Widget expressions: Fix screen object not properly initialized & updated #2933

merged 2 commits into from
Dec 22, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2929.

@florian-h05 florian-h05 requested a review from ghys as a code owner December 19, 2024 17:42
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 19, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 19, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Dec 19, 2024 •
edited
Loading

#2578 Bundle Size — 10.9MiB (~+0.01%).

cf8c00f(current) vs 56e0ebe main#2576(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2578		      Baseline
#2576
Regression  Initial JS 1.92MiB(~+0.01%) 1.92MiB
No change  Initial CSS 577.83KiB 577.83KiB
No change  Cache Invalidation 17.58% 17.58%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2578		      Baseline
#2576
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
No change  CSS 866.74KiB 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:widget-expr-screen Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05
Add comment
cf8c00f 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 merged commit 0ead7b8 into openhab:main Dec 22, 2024
6 checks passed
@florian-h05 florian-h05 deleted the widget-expr-screen branch December 22, 2024 00:48
@florian-h05 florian-h05 mentioned this pull request Dec 22, 2024
Closed
florian-h05 added a commit that referenced this pull request Dec 22, 2024
@florian-h05
Widget expressions: Fix screen object not properly initialized & upda…
ebbebb7 
…ted (#2933)

Fixes #2929.

Signed-off-by: Florian Hotze <[email protected]>
(cherry picked from commit 0ead7b8)
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[Main UI] screen.viewAreaWidth not updating / working
1 participant
@florian-h05