Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripting add-on availability check for old JS Scripting MIME type #2928

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

florian-h05
Copy link
Contributor

Regression from #2743.

@florian-h05 florian-h05 force-pushed the fix-scripting-addon-check branch from 8499e3d to 5359bad Compare December 17, 2024 15:06
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 17, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 17, 2024
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Dec 17, 2024
Copy link

relativeci bot commented Dec 17, 2024

#2567 Bundle Size — 10.9MiB (~+0.01%).

5359bad(current) vs c2ae0ab main#2562(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2567
     Baseline
#2562
No change  Initial JS 1.92MiB 1.92MiB
No change  Initial CSS 577.83KiB 577.83KiB
Change  Cache Invalidation 17.83% 17.65%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2567
     Baseline
#2562
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
No change  CSS 866.74KiB 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch fix-scripting-addon-checkProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 marked this pull request as ready for review December 17, 2024 15:14
@florian-h05 florian-h05 requested a review from ghys as a code owner December 17, 2024 15:14
@florian-h05 florian-h05 merged commit 511b949 into main Dec 17, 2024
9 checks passed
@florian-h05 florian-h05 deleted the fix-scripting-addon-check branch December 17, 2024 15:14
florian-h05 added a commit that referenced this pull request Dec 17, 2024
#2928)

Regression from #2743.

Signed-off-by: Florian Hotze <[email protected]>
(cherry picked from commit 511b949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant