Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Fix description for iconify parameter #2660

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 9, 2024

Default is enabled, not disabled.

Signed-off-by: Laurent Garnier [email protected]

Default is enabled, not disabled.

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Jul 9, 2024
@lolodomo lolodomo requested a review from a team as a code owner July 9, 2024 20:00
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backported to 4.2.x?

@florian-h05 florian-h05 added this to the 4.3 milestone Jul 22, 2024
@florian-h05 florian-h05 merged commit 24a3d27 into openhab:main Jul 22, 2024
5 checks passed
@lolodomo lolodomo deleted the iconify_default_descr branch July 22, 2024 13:57
@lolodomo
Copy link
Contributor Author

Should this be backported to 4.2.x?

Yes please.

florian-h05 pushed a commit that referenced this pull request Jul 23, 2024
Default is enabled, not disabled.

Signed-off-by: Laurent Garnier <[email protected]>
(cherry picked from commit 24a3d27)
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Jul 23, 2024
@florian-h05
Copy link
Contributor

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants