Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Prefer sitemap label to name in sitemap selection #2110

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 6, 2023

Sitemaps are now also sorted by label/name.
Dark theme is now properly handled.

In case several sitemaps have the same label, the sitemap name is concatenated in parenthesis.

Fix #2101

Signed-off-by: Laurent Garnier [email protected]

Sitemaps are now also sorted by label/name.
Dark theme is now properly handled.

Fix openhab#2101

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI labels Oct 6, 2023
@lolodomo lolodomo requested a review from a team as a code owner October 6, 2023 06:39
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 6, 2023

Here is the result before.
In bright theme:
image

In dark theme:
image

And now the new result.
In bright theme:
image

In dark theme:
image

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit c76a8e3 into openhab:main Oct 6, 2023
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 6, 2023
@lolodomo lolodomo deleted the basicui_list_sitemaps branch October 6, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Basic UI] Use sitemap labels in sitemap selection
2 participants