Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Tags in the Items list (/settings/items/) #2086

Closed
Davek145 opened this issue Sep 23, 2023 · 0 comments · Fixed by #2087
Closed

[MainUI] Tags in the Items list (/settings/items/) #2086

Davek145 opened this issue Sep 23, 2023 · 0 comments · Fixed by #2087
Labels
enhancement New feature or request main ui Main UI

Comments

@Davek145
Copy link
Contributor

The problem

Different to Rules / Scripts / Pages non-semantic Tags are not displayed in list of Items (/settings/items/). In addition, the subtitle of an Item in the list displays only class of the Semantic classification (e.g. Measurement), but not relatesTo part (e.g. Humidity).

There is also small bug in this settings page. For the Chrome and Edge browser, where the height of vue virtual box is not correctly calculated. It is caused by rounding of provided height of the list row that for large list of Items becomes visible.

Your suggestion

Extend items-list-vlist.vue (/settings/items/) to display Tags consistent with similar list of Rules / Scripts / Pages.

Your environment

runtimeInfo:
version: 4.0.3
buildString: Release Build
locale: cs-CZ
systemInfo:
configFolder: /etc/openhab
userdataFolder: /var/lib/openhab
logFolder: /var/log/openhab
javaVersion: 17.0.8.1
javaVendor: Azul Systems, Inc.
javaVendorVersion: Zulu17.44+53-CA
osName: Linux
osVersion: 5.4.0-162-generic
osArchitecture: amd64
startLevel: 100
clientInfo:
device:
ios: false
android: false
androidChrome: false
desktop: true
iphone: false
ipod: false
ipad: false
edge: false
ie: false
firefox: false
macos: false
windows: true
cordova: false
phonegap: false
electron: false
nwjs: false
webView: false
webview: false
standalone: false
os: windows
pixelRatio: 1
prefersColorScheme: light
isSecureContext: true
locationbarVisible: true
menubarVisible: true
navigator:
cookieEnabled: true
deviceMemory: 8
hardwareConcurrency: 8
language: cs-CZ
languages:

cs-CZ
cs
en
sk
onLine: true
platform: Win32
screen:
width: 1920
height: 1080
colorDepth: 24
support:
touch: false
pointerEvents: true
observer: true
passiveListener: true
gestures: false
intersectionObserver: true
themeOptions:
dark: light
filled: true
pageTransitionAnimation: default
bars: filled
homeNavbar: default
homeBackground: default
expandableCardAnimation: default
userAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/116.0.0.0 Safari/537.36
@Davek145 Davek145 added enhancement New feature or request main ui Main UI labels Sep 23, 2023
@Davek145 Davek145 mentioned this issue Sep 23, 2023
Merged
florian-h05 pushed a commit that referenced this issue Sep 26, 2023
@Davek145
Items tag: added tags to list, unification of items tag edit (#2087)
05c3417 
Closes #2086

- Adds Non-semantic tags to Items list (e.g. /settings/items/)
consistently with similar list of Rules / Scripts / Pages.
- Extends `getItemTypeAndMetaLabel` with relatesTo part of Semantic
classification and moves it to a mixin.
- Fixes incorrect calculation of vue virtual box height on Items list.
- Replaces custom tag input with accordion tag input (inspired by
#2078) and show number of
tags (inspired by #2083).
- Moves the custom tag input to `item-form.vue`, so it is available also
in Model view, when creating Item from Thing etc.

Also-by: Florian Hotze <[email protected]>
Signed-off-by: David Kesl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
No milestone
1 participant
@Davek145