Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules] Adjust event object for recent core changes #260

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

florian-h05
Copy link
Contributor

openhab/openhab-core#3141 changed the events that are passed to the rule for **StateUpdateTriggers. This adds support for the changed classnames whilst keeping backward compatibility.

openhab/openhab-core#3141 changed the events
that are passed to the rule for **StateUpdateTriggers. This adds
support for the changed classnames whilst keeping backward
compatibility.

Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 added the bug Something isn't working label Apr 5, 2023
@florian-h05 florian-h05 added this to the to be released milestone Apr 5, 2023
@florian-h05
Copy link
Contributor Author

florian-h05 commented Apr 5, 2023

@digitaldan
Can you please review this, it is an important, critical fix for a breaking change in core.

I will release a new version after this ASAP.

Signed-off-by: Florian Hotze <[email protected]>
Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-h05 florian-h05 merged commit a397450 into openhab:main Apr 6, 2023
@florian-h05 florian-h05 deleted the rules-event-changes branch April 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants