Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemStateUpdatedEvent added in openHAB 4 caused updated triggers to fail #49

Merged
merged 1 commit into from
Apr 4, 2023
Merged

ItemStateUpdatedEvent added in openHAB 4 caused updated triggers to fail #49

merged 1 commit into from
Apr 4, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Apr 1, 2023

ItemStateUpdatedEvent was added here: openhab/openhab-core#3141

updated rules couldn't get event.state because of it.

@jimtng jimtng requested a review from ccutrer April 1, 2023 16:24
@jimtng
Copy link
Contributor Author

jimtng commented Apr 2, 2023 •
edited
Loading

It seems that the problem with spec/openhab/dsl/rules/builder_spec.rb:905 (update trigger on GroupItem) is within core (snapshot) itself. Nothing to do (at this point) with our library.

I tried creating the same trigger using MainUI and still didn't receive any events at all. So I've commented out that test for now until I can get to the bottom of it.

@jimtng jimtng mentioned this pull request Apr 4, 2023
Merged
@jimtng jimtng force-pushed the item_state_updated_event branch 2 times, most recently from 7194229 to 8f3aa53 Compare April 4, 2023 09:22
@jimtng jimtng added the bug Something isn't working label Apr 4, 2023
@jimtng
support ItemStateUpdatedEvent
4bff541 
Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng requested a review from ccutrer April 4, 2023 21:57
@ccutrer ccutrer merged commit 6d62fc2 into openhab:main Apr 4, 2023
@jimtng jimtng changed the title support ItemStateUpdatedEvent Support ItemStateUpdatedEvent in OpenHAB 4.0 Apr 5, 2023
@jimtng jimtng changed the title Support ItemStateUpdatedEvent in OpenHAB 4.0 Support ItemStateUpdatedEvent in openHAB 4.0 Apr 5, 2023
@jimtng jimtng changed the title Support ItemStateUpdatedEvent in openHAB 4.0 ItemStateUpdatedEvent added in openHAB 4 caused updated triggers to fail Apr 6, 2023
@jimtng jimtng deleted the item_state_updated_event branch April 16, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccutrer ccutrer ccutrer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @ccutrer