Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy] adds new check for updated app and provides an in app upgrade experience #763

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

digitaldan
Copy link
Contributor

No description provided.

@digitaldan digitaldan requested review from timbms and weakfl June 9, 2024 21:26
@digitaldan
Copy link
Contributor Author

This will check a public API endpoint on myopenhab (no auth) for the latest app id. If its different then the bundled app id, the app will present the following view each time the app is launched new, unless the user disables the the reminder toggle. This uses StoreKit, so the upgrade view happens inside the app which is nice. Also if an upgrade is available, the settings menu "About" will change to "Upgrade Available!" and clicking on that will also bring up this view.

IMG_0562

IMG_0563

IMG_0564

@digitaldan digitaldan changed the title adds new check for updated app and provides an in app upgrade experience [legacy] adds new check for updated app and provides an in app upgrade experience Jun 9, 2024
@digitaldan
Copy link
Contributor Author

@weakfl @timbms if there are no objections i'll merge this in. I was thinking about some complicated weekly or other timed reminder, but in the end i decided to keep it simple (ish).

Signed-off-by: Dan Cunningham <[email protected]>
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Copy link
Contributor Author

I think our CI job is failing here b/c of this issue?

actions/runner-images#9591

@digitaldan digitaldan merged commit 72c9439 into openhab:openhab-legacy Jun 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants