Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gh-pages to master #733

Merged
merged 6 commits into from
Jul 8, 2018
Merged

Merge gh-pages to master #733

merged 6 commits into from
Jul 8, 2018

Conversation

ghys
Copy link
Member

@ghys ghys commented Jul 8, 2018

Related to #700 (comment).

This will merge the changes made to the current gh-pages branch to the new master branch since it was created.

Signed-off-by: Yannick Schaus [email protected]

cweitkamp and others added 6 commits June 17, 2018 12:09
* Clarify Contact 

I spent hours trying to find the problem, as I was trying to send a command to a contact. I think it should be mentioned a contact item only accepts status, and the 'CommandType' should be renamed OpenClosed with a D as the status is in fact CLOSED and not CLOSE. Less confusing this way.

* Update items.md

Sign off from PR comment:
Signed-off-by: Bas Stronks [email protected] (github: DomQuixote)

* Reverted concept changes to make pr ready for merge.

Signed-off-by: Jerome Luckenbach <[email protected]>

* Revert really everything

Signed-off-by: Jerome Luckenbach <[email protected]>
@ghys ghys requested a review from Confectrician July 8, 2018 13:20
@ghys
Copy link
Member Author

ghys commented Jul 8, 2018

I think a rebase & merge is the way to go for this.

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy review, since i merged most of those anyway into gh-pages. 😄

Looks good an i would agree with the rebase.
So LGTM.

@Confectrician Confectrician merged commit e63e744 into master Jul 8, 2018
@Confectrician Confectrician added this to the 2.x.x milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants