Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for scale transformation #2252

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 24, 2024

Do svg icons need to be accompanied by their png version?

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they don't, correct @florian-h05.
Thanks for adding it, Jim.

@stefan-hoehn stefan-hoehn merged commit 6f39e14 into openhab:main Feb 24, 2024
@florian-h05
Copy link
Contributor

No, PNG icons are not needed anymore.
@jimtng Do you mind replacing the icons you recently added with SVG versions?

@jimtng jimtng deleted the scale-icon branch February 25, 2024 02:42
@jimtng
Copy link
Contributor Author

jimtng commented Feb 25, 2024

#2253

pgfeller added a commit to pgfeller/openhab-docs that referenced this pull request Feb 25, 2024
commit 6774910
Author: jimtng <[email protected]>
Date:   Sun Feb 25 17:23:01 2024 +1000

    Convert pwm, pid, map icons to svg and add jinja logo (openhab#2253)

    * Replace map icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Replace pidcontroller icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Replace pwm icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Add jinja logo

    Signed-off-by: Jimmy Tanagra <[email protected]>

    ---------

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 6f39e14
Author: jimtng <[email protected]>
Date:   Sun Feb 25 08:15:21 2024 +1000

    Add icon for scale transformation (openhab#2252)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 67a019a
Author: jimtng <[email protected]>
Date:   Sun Feb 25 00:55:02 2024 +1000

    Add pwm icon (openhab#2251)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit a03e4c0
Author: jimtng <[email protected]>
Date:   Sun Feb 25 00:54:22 2024 +1000

    PIDController icon: Make lines thicker (openhab#2250)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 7308a41
Author: Kai Kreuzer <[email protected]>
Date:   Sat Feb 24 14:57:54 2024 +0100

    Fix typo in tutorial (openhab#2249)

    Signed-off-by: Kai Kreuzer <[email protected]>

commit ccb7e64
Author: jimtng <[email protected]>
Date:   Sat Feb 24 18:15:21 2024 +1000

    Make basicui icon a bit bigger and more visible (openhab#2247)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit d9664d9
Author: jimtng <[email protected]>
Date:   Sat Feb 24 18:10:22 2024 +1000

    Add icon for pidcontroller (openhab#2248)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit bcba38e
Author: jimtng <[email protected]>
Date:   Sat Feb 24 08:31:23 2024 +1000

    Add an icon for map transformation (openhab#2240)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit f8ebab4
Author: jimtng <[email protected]>
Date:   Sat Feb 24 03:23:06 2024 +1000

    Add icon for Basic UI (openhab#2242)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit ab958f9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 23 18:21:57 2024 +0100

    Bump ip from 1.1.5 to 1.1.9 (openhab#2244)

    Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9.
    - [Commits](indutny/node-ip@v1.1.5...v1.1.9)

    ---
    updated-dependencies:
    - dependency-name: ip
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: stefan-hoehn <[email protected]>

commit dedb16a
Author: Florian Hotze <[email protected]>
Date:   Fri Feb 23 16:52:57 2024 +0100

    Use SVG logos for DoorBird & Govee (openhab#2246)

    Signed-off-by: Florian Hotze <[email protected]>

commit 749a656
Author: jimtng <[email protected]>
Date:   Fri Feb 23 18:29:36 2024 +1000

    Add sqlite icon (openhab#2238)

    Signed-off-by: Jimmy Tanagra <[email protected]>

Signed-off-by: Patrik Gfeller <[email protected]>
stefan-hoehn added a commit that referenced this pull request Mar 2, 2024
#2218)

* [Enancement] - Simplify local builds to lower bar for beginners
Fixes #2215

* [Enancement] - Simplify local builds to lower bar for beginners
Fixes #2215

📄 missing `npm install step` added to README.md

Signed-off-by: Patrik Gfeller <[email protected]>

* 🐞 problems resolved after reabse/update to latest main branch.

Signed-off-by: Patrik Gfeller <[email protected]>

* 🔃 Squashed commit of the following:

commit 6774910
Author: jimtng <[email protected]>
Date:   Sun Feb 25 17:23:01 2024 +1000

    Convert pwm, pid, map icons to svg and add jinja logo (#2253)

    * Replace map icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Replace pidcontroller icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Replace pwm icon with svg version

    Signed-off-by: Jimmy Tanagra <[email protected]>

    * Add jinja logo

    Signed-off-by: Jimmy Tanagra <[email protected]>

    ---------

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 6f39e14
Author: jimtng <[email protected]>
Date:   Sun Feb 25 08:15:21 2024 +1000

    Add icon for scale transformation (#2252)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 67a019a
Author: jimtng <[email protected]>
Date:   Sun Feb 25 00:55:02 2024 +1000

    Add pwm icon (#2251)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit a03e4c0
Author: jimtng <[email protected]>
Date:   Sun Feb 25 00:54:22 2024 +1000

    PIDController icon: Make lines thicker (#2250)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit 7308a41
Author: Kai Kreuzer <[email protected]>
Date:   Sat Feb 24 14:57:54 2024 +0100

    Fix typo in tutorial (#2249)

    Signed-off-by: Kai Kreuzer <[email protected]>

commit ccb7e64
Author: jimtng <[email protected]>
Date:   Sat Feb 24 18:15:21 2024 +1000

    Make basicui icon a bit bigger and more visible (#2247)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit d9664d9
Author: jimtng <[email protected]>
Date:   Sat Feb 24 18:10:22 2024 +1000

    Add icon for pidcontroller (#2248)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit bcba38e
Author: jimtng <[email protected]>
Date:   Sat Feb 24 08:31:23 2024 +1000

    Add an icon for map transformation (#2240)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit f8ebab4
Author: jimtng <[email protected]>
Date:   Sat Feb 24 03:23:06 2024 +1000

    Add icon for Basic UI (#2242)

    Signed-off-by: Jimmy Tanagra <[email protected]>

commit ab958f9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 23 18:21:57 2024 +0100

    Bump ip from 1.1.5 to 1.1.9 (#2244)

    Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9.
    - [Commits](indutny/node-ip@v1.1.5...v1.1.9)

    ---
    updated-dependencies:
    - dependency-name: ip
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: stefan-hoehn <[email protected]>

commit dedb16a
Author: Florian Hotze <[email protected]>
Date:   Fri Feb 23 16:52:57 2024 +0100

    Use SVG logos for DoorBird & Govee (#2246)

    Signed-off-by: Florian Hotze <[email protected]>

commit 749a656
Author: jimtng <[email protected]>
Date:   Fri Feb 23 18:29:36 2024 +1000

    Add sqlite icon (#2238)

    Signed-off-by: Jimmy Tanagra <[email protected]>

Signed-off-by: Patrik Gfeller <[email protected]>

* Update README.md

Signed-off-by: stefan-hoehn <[email protected]>

* Update README.md

Signed-off-by: stefan-hoehn <[email protected]>

---------

Signed-off-by: Patrik Gfeller <[email protected]>
Signed-off-by: stefan-hoehn <[email protected]>
Co-authored-by: stefan-hoehn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants