Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-external-resource: Google Assistant USAGE #690

Closed
ThomDietrich opened this issue May 26, 2018 · 4 comments
Closed

Update-external-resource: Google Assistant USAGE #690

ThomDietrich opened this issue May 26, 2018 · 4 comments

Comments

@ThomDietrich
Copy link
Member

Thanks to @marziman there is now a USAGE.md to be pulled over (or integrated. I'm currently not in ther loop regarding the whole website endeavor)

All details: openhab/openhab-google-assistant#33

@Confectrician
Copy link
Contributor

@ghys can we pull this directly through website generation or do we need to pull it over to the docs first?

Or do i rush too fast and should we wait for a/the new generation process to be finished?

@ghys
Copy link
Member

ghys commented Jun 13, 2018

It should transit through here like the Alexa & Mycroft skills I think - so they can be versioned, tagged along with the rest of the docs.
IMO It seems counterintuitive to treat those external skills as "io" add-ons though (they're not add-ons), maybe that's something to improve in the process along with the automation, but it's not too important either: the website prepare-docs script knows about them and moves them in the "ecosystem" section as appropriate.

@ThomDietrich
Copy link
Member Author

ThomDietrich commented Jun 14, 2018

@ghys at the time there was no better place to put them and from the end users perspective they are "integrations" just as the others (addons). I was btw never really satisfied with the "Add-ons" menu title. It is a technical term and excludes a lot of valid candidates (like the Google Assistant or let's say loosely linked integration of Grafana, maybe not the best example)

Anyhow. For now I'd say let's just add it to the update-external-resources script. @Confectrician would you like to try? Hint: The USAGE.md currently misses the font matter header, you might need to open a PR for that.

@Confectrician
Copy link
Contributor

would you like to try?

I can do that.
From what i see it isn't done only with update external ressource correct?
I have to add it to the pom.xml like the alexa one.

Hint: The USAGE.md currently misses the font matter header, you might need to open a PR for that.

Will take care of that first. 👍

@Confectrician Confectrician self-assigned this Jun 14, 2018
ghys added a commit to ghys/openhab-website that referenced this issue Jan 12, 2019
Add hot rewrite for wrong image relative path.

Related to openhab/openhab-docs#721.
Related to openhab/openhab-docs#690.

Signed-off-by: Yannick Schaus <[email protected]>
ghys added a commit to openhab/website that referenced this issue Jan 12, 2019
* Copy Google Assistant page + images from openhab-docs repo

Add hot rewrite for wrong image relative path.

Related to openhab/openhab-docs#721.
Related to openhab/openhab-docs#690.

Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants