Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tapocontrol] Change naming of things #1361

Merged
merged 2 commits into from
Jan 10, 2022
Merged

[tapocontrol] Change naming of things #1361

merged 2 commits into from
Jan 10, 2022

Conversation

wildcs
Copy link
Contributor

@wildcs wildcs commented Jan 10, 2022

changed naming of things because manufacturer changed namin in new hw-rev.
now all things have the same naming-style

@wildcs wildcs requested a review from a team as a code owner January 10, 2022 12:53
kaikreuzer
kaikreuzer requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reference to the PR that brought this breaking change?
Was it really necessary to introduce this breaking change? I would have thought that it shouldn't harm, if we have a "_Series" suffix still in place.

distributions/openhab/src/main/resources/bin/update.lst Outdated Show resolved Hide resolved
kaikreuzer
kaikreuzer approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you!

@kaikreuzer kaikreuzer changed the title [tapocontrol] changed naming of things [tapocontrol] Changed naming of things Jan 10, 2022
@kaikreuzer kaikreuzer changed the title [tapocontrol] Changed naming of things [tapocontrol] Change naming of things Jan 10, 2022
@kaikreuzer kaikreuzer merged commit 995fe61 into openhab:main Jan 10, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Jan 10, 2022
@lolodomo lolodomo mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wildcs @kaikreuzer