Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inital loading and improve code for YAML model #4199

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix inital loading and improve code for YAML model #4199

merged 1 commit into from
Apr 30, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Apr 27, 2024

Fixes #4196

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Apr 27, 2024
@J-N-K J-N-K requested a review from a team as a code owner April 27, 2024 09:50
@lolodomo
Copy link
Contributor

lolodomo commented Apr 29, 2024 •
edited
Loading

LGTM
Looks like you made another change not linked to the referenced issue by enabling Feature.PARSE_BOOLEAN_LIKE_WORDS_AS_STRINGS.

I guess that it is what you call "improve code for YAML model" ;)

@J-N-K
Copy link
Member Author

J-N-K commented Apr 30, 2024

Yes, that was part of #4085, if this is not set, the strings ON, YES, TRUE (and abbreviations like Y or variants like yes/Yes) are parsed as boolean true. This is obviously wrong for our usage, only true should be parsed as true.

holgerfriedrich
holgerfriedrich approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich added this to the 4.2 milestone Apr 30, 2024
@holgerfriedrich holgerfriedrich merged commit 551c06b into openhab:main Apr 30, 2024
5 checks passed
@J-N-K J-N-K deleted the fix-yaml branch May 1, 2024 07:59
@jimtng
Copy link
Contributor

jimtng commented May 1, 2024

Typo in PR title inital

@lolodomo
Copy link
Contributor

lolodomo commented May 6, 2024

I can confirm it works as expected in snapshot 4064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

customTags.yaml not loading after reboot
4 participants
@J-N-K @lolodomo @jimtng @holgerfriedrich