Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide unit hint for system channel type atmospheric-humidity #4170

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Provide unit hint for system channel type atmospheric-humidity #4170

merged 1 commit into from
Apr 7, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 5, 2024

Depends on #4079

@jlaur jlaur requested a review from a team as a code owner April 5, 2024 13:59
mherwege
mherwege approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewfg
andrewfg approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

@jlaur jlaur mentioned this pull request Apr 5, 2024
Merged
@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 6, 2024
@jlaur
Copy link
Contributor Author

jlaur commented Apr 6, 2024

@J-N-K - I don't think rebuild will help until #4079 is merged. 😉

@J-N-K
Copy link
Member

J-N-K commented Apr 6, 2024

I thought I had pressed merge yesterday...

@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 6, 2024
@kaikreuzer
Copy link
Member

@J-N-K Ok to merge now?

J-N-K
J-N-K approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K merged commit 258b099 into openhab:main Apr 7, 2024
3 checks passed
@J-N-K J-N-K added this to the 4.2 milestone Apr 7, 2024
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Apr 7, 2024
@jlaur jlaur deleted the 3854-humidity-unit-hint branch April 7, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherwege mherwege mherwege approved these changes

@J-N-K J-N-K J-N-K approved these changes

@andrewfg andrewfg andrewfg approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@jlaur @J-N-K @kaikreuzer @andrewfg @mherwege @wborn