Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sitemap visibility rule with blanks #3769

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

mherwege
Copy link
Contributor

See openhab/openhab-webui#1487 (comment)

Sitemap visibility and color rules, maintained in mainUI failed with blanks in the condition state. This happens because string quotes are stripped from the json REST format.

This fix modifies the regex identifying the condition states to allow any character, with the exception of = in color rules, as that will identify the target color.

@mherwege mherwege requested a review from a team as a code owner August 21, 2023 15:09
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Aug 26, 2023
@J-N-K J-N-K added this to the 4.1 milestone Aug 26, 2023
@J-N-K J-N-K merged commit 096d11b into openhab:main Aug 26, 2023
@mherwege mherwege deleted the sitemap_visibility_fix branch August 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants