[audio] Improve audio duration computation #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalgwen
force-pushed
the
improve_audio_duration_computation
branch
from
3e0275a to
58244bd
Compare
13 tasks
lolodomo
suggested changes
Jul 1, 2023
| @@ -102,7 +104,9 @@ public AudioFormat getFormat() { | |||
|
|
|||
| @Override | |||
| public int read() throws IOException { | |||
| return inputStream.read(); | |||
| int read = inputStream.read(); | |||
| alreadyRead++; | |||
There was a problem hiding this comment.
Isn't it rather alreadyRead += read; ?
There was a problem hiding this comment.
The "alreadyRead" counter is the amount of bytes read.
The read() method reads only one byte and return the value of this byte.
So just +1 at every call.
| logger.debug("Cannot compute the duration of input stream with method java stream sound analysis", | ||
| e); | ||
| Integer bitRate = audioFormat.getBitRate(); | ||
| Integer channel = audioFormat.getChannels(); |
There was a problem hiding this comment.
channel is then apparently not used, is it normal ?
There was a problem hiding this comment.
Good catch. I used this on a previous try but it is not needed.
I will remove it.
Allows the use of a Sizeable interface (for AudioStream that we know the length of, but we cannot clone). We can then improve the duration detection, for example for the pulseaudio sink (PR coming after). We can also give the length information to sink in more cases. Add the support of the mark / reset methods to some common AudioStream. We then allow more stream analysis for sink requiring it (Stream analysis often requires to get back in time after consuming a few bytes) Signed-off-by: Gwendal Roulleau <[email protected]>
dalgwen
force-pushed
the
improve_audio_duration_computation
branch
from
58244bd to
5fd27ca
Compare
|
Build failed in "Automation Integration Tests". Not sure it have any link with your PR. |
kaikreuzer
added
rebuild
kaikreuzer
approved these changes
Jul 2, 2023
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Allows the use of a Sizeable interface (for AudioStream that we know the length of, but we cannot clone). We can then improve the duration detection, for example for the pulseaudio sink (PR coming after). We can also give the length information to sink in more cases. Add the support of the mark / reset methods to some common AudioStream. We then allow more stream analysis for sink requiring it (Stream analysis often requires to get back in time after consuming a few bytes) Signed-off-by: Gwendal Roulleau <[email protected]> GitOrigin-RevId: 3ec1457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another way of computing sound duration (using information from the AudioFormat class)
Allows the use of a "Sizeable" interface (for AudioStream that we know the length of, but we cannot clone). We can then improve the success of the duration detection, for example for the pulseaudio sink (PR coming after). We can also give the length information to sink in more cases, even if we cannot clone the stream.
Add the support of the mark / reset methods to some common AudioStream. We then allow more stream analysis for sink requiring it (Stream analysis often requires to get back in time after consuming a few bytes)