Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] List semantic tags #3559

Merged
merged 4 commits into from
Apr 20, 2023
Merged

[REST] List semantic tags #3559

merged 4 commits into from
Apr 20, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Apr 16, 2023

This is to enable the use of dynamically added tags (#3519) in the main ui (openhab/openhab-webui#1850)

jimtng added 2 commits April 16, 2023 23:01
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng requested a review from a team as a code owner April 16, 2023 16:45
@jimtng jimtng marked this pull request as draft April 17, 2023 09:46
@jimtng jimtng marked this pull request as ready for review April 18, 2023 06:28
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaikreuzer kaikreuzer merged commit bc92202 into openhab:main Apr 20, 2023
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Apr 20, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Apr 20, 2023
@jimtng jimtng deleted the tag-rest branch April 20, 2023 20:31
ghys pushed a commit to openhab/openhab-webui that referenced this pull request Jun 28, 2023
)

Supersedes #1850.
Closes #1822.

Depends on openhab/openhab-core#3559 (already
merged now).
Adding custom semantic tags is now possible:
openhab/openhab-core#3519.

This PR loads the Semantic tags when MainUI is loaded the first time and
stores them in Vuex.
This allows the removal of the hard-coded Semantic tags and the
translations from the assets and therefore makes the initial JS smaller.

--
Signed-off-by: Florian Hotze <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jimmy Tanagra <[email protected]>
GitOrigin-RevId: bc92202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants