-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REST] List semantic tags #3559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
kaikreuzer
requested changes
Apr 20, 2023
....core.io.rest.core/src/main/java/org/openhab/core/io/rest/core/internal/tag/TagResource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jimmy Tanagra <[email protected]>
kaikreuzer
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ghys
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Jun 28, 2023
) Supersedes #1850. Closes #1822. Depends on openhab/openhab-core#3559 (already merged now). Adding custom semantic tags is now possible: openhab/openhab-core#3519. This PR loads the Semantic tags when MainUI is loaded the first time and stores them in Vuex. This allows the removal of the hard-coded Semantic tags and the translations from the assets and therefore makes the initial JS smaller. -- Signed-off-by: Florian Hotze <[email protected]>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jimmy Tanagra <[email protected]> GitOrigin-RevId: bc92202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable the use of dynamically added tags (#3519) in the main ui (openhab/openhab-webui#1850)