[oauth] Fix InaccessibleObjectException

[jlaur]

This fixes a regression from #3083 and #2994 since JDK internals are now strongly encapsulated. The first mentioned PR removed the type adapter for LocalDateTime, which ultimately lead to the issue when Java 17 was introduced.

Since type adapters already exist for Instant, the InaccessibleObjectException has been fixed by refactoring remaining LocalDateTimes to Instant.

JAR: org.openhab.core.auth.oauth2client-4.0.0-SNAPSHOT.jar

Fixes #3447

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh4-0-0-snapshot-and-m1-google-tts-exception/145046/17

[wborn]

the InaccessibleObjectException has been fixed by refactoring remaining LocalDateTimes to Instant.

Will this change cause everybody having to setup new tokens or can it be made backwards compatible?

[jlaur]

Will this change cause everybody having to setup new tokens or can it be made backwards compatible?

Backwards compatibility should already be ensured by fallback to LocalDateTime:

openhab-core/bundles/org.openhab.core.auth.oauth2client/src/main/java/org/openhab/core/auth/oauth2client/internal/OAuthStoreHandlerImpl.java

Lines 244 to 250 in 73b8a3a

	.registerTypeAdapter(Instant.class, (JsonDeserializer<Instant>) (json, typeOfT, context) -> {
	try {
	return Instant.parse(json.getAsString());
	} catch (DateTimeParseException e) {
	return LocalDateTime.parse(json.getAsString()).atZone(ZoneId.systemDefault()).toInstant();
	}
	})

[jlaur]

I have tested with the Miele Cloud binding.

StorageHandler.For.OAuthClientService.json differences

Before: (4.0 and 3.4.x)

  "[email protected]": {
    "class": "java.lang.String",
    "value": "{\n  \"date\": {\n    \"year\": 2023,\n    \"month\": 3,\n    \"day\": 14\n  },\n  \"time\": {\n    \"hour\": 23,\n    \"minute\": 47,\n    \"second\": 1,\n    \"nano\": 502530800\n  }\n}"
  },

Now: (this PR)

  "[email protected]": {
    "class": "java.lang.String",
    "value": "\"2023-03-14T22:56:01.498029Z\""
  },

AccessTokenResponse was already using a well-formatted Instant string for createdOn.

For backwards compatibility we might need to be able to deserialize something like "{\n "date": {\n "year": 2023,\n "month": 3,\n "day": 14\n },\n "time": {\n "hour": 23,\n "minute": 47,\n "second": 1,\n "nano": 502530800\n }\n}" also.

[jlaur]

For backwards compatibility we might need to be able to deserialize something like "{\n "date": {\n "year": 2023,\n "month": 3,\n "day": 14\n },\n "time": {\n "hour": 23,\n "minute": 47,\n "second": 1,\n "nano": 502530800\n }\n}" also.

It seems to be handled here already (now changed to Instant):

openhab-core/bundles/org.openhab.core.auth.oauth2client/src/main/java/org/openhab/core/auth/oauth2client/internal/OAuthStoreHandlerImpl.java

Lines 308 to 314 in c05fe8a

	try {
	LocalDateTime lastUsedDate = gson.fromJson(value, LocalDateTime.class);
	return lastUsedDate;
	} catch (Exception e) {
	logger.info("Unable to deserialize json, reset LAST_USED to now. json:\n{}", value);
	return LocalDateTime.now();
	}

[jlaur]

The exceptions reported in the linked issue are fixed, so I'm marking this as ready for review. There are still some issues being sorted out (see details in the issue), but at this point I think it's unrelated and should not block the fixes provided here any longer.

[jlaur]

The fix has now been tested and confirmed by the user.

[wborn]

LGTM! 👍