Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements for add-on services #3293

Merged
merged 8 commits into from
Jan 21, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 2, 2023

Follow-Up to #3050
Fixes #3323
Needs to be merged together with openhab/openhab-webui#1651

  • Adds an add-on service that provides add-ons from JARs in the addons-folder. This is needed to show manually added add-ons in the UI. It's useful because then add-ons can be configured from UI or their log-level changed (see Allow changing log-levels for add-ons openhab-webui#1452). It is also needed to install things from bindings installed via .jar files
  • Fixes issues with community-marketplace and JSON 3rd party add-on services. Due to inconsistent use of add-on ids throughout core and Main UI add-ons from these services could not be installed.
  • Fixes issues with parsing addon.xml (connection and countries)

For better handling the id and the uid of an add-on has been splitter. The id (e.g. dmx) is used to determine the thing-type. The uid (binding-dmx) is used for installation and identification of the binding. For a binding named foo this would result in

  • Karaf (distribution) add-on service: id foo, uid binding-foo
  • Community-Marketplace add-on service: id foo, uid marketplace:123456
  • JSON 3rd party add-on service: id foo, uid json:arbitrary-identifier-foo-addon
  • JAR file add-on service: id foo, uid jar:binding-foo

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Jan 2, 2023
@J-N-K J-N-K force-pushed the feature-fileaddonservice branch from 9bd2d87 to 403d2a2 Compare January 3, 2023 20:19
J-N-K added 2 commits January 18, 2023 08:36
This is needed to show the add-ons from the addons in the UI.

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K changed the title Add an add-on service that provides add-ons in the addons-folder Add an add-on service that provides add-ons from JARs in the addons-folder Jan 18, 2023
@J-N-K J-N-K force-pushed the feature-fileaddonservice branch from 403d2a2 to f96054c Compare January 18, 2023 08:46
J-N-K added 3 commits January 18, 2023 23:24
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of the Core critical labels Jan 19, 2023
@J-N-K J-N-K changed the title Add an add-on service that provides add-ons from JARs in the addons-folder Fixes and enhancements for add-on services Jan 19, 2023
@J-N-K J-N-K marked this pull request as ready for review January 19, 2023 18:41
@J-N-K J-N-K requested a review from a team as a code owner January 19, 2023 18:41
J-N-K added 2 commits January 19, 2023 20:44
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/question-about-new-binding-metadata-changes-to-core/143624/2

…al/addon/JarFileAddonService.java

Co-authored-by: Kai Kreuzer <[email protected]>
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jan 21, 2023
@kaikreuzer kaikreuzer merged commit 6738277 into openhab:main Jan 21, 2023
@J-N-K J-N-K deleted the feature-fileaddonservice branch January 21, 2023 21:11
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/121

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Add an add-on service that provides add-ons in the addons-folder
* fix connection and countries

This is needed to show the add-ons from the addons in the UI.

Signed-off-by: Jan N. Klug <[email protected]>
GitOrigin-RevId: 6738277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core critical enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add thing from binding dropped as JAR
3 participants