[semantics] Added properties Distance and Angle #2021
Conversation
Proposal is to add Distance and Angle as additional property this allows to use these basic units for items. Signed-off-by: Michael Roßner <[email protected]>
cweitkamp
added
rebuild
cweitkamp
changed the title
|
Thank you very much for your first contribution. And sorry for our late response. May I ask you to prepare a related PR in https://github.com/openhab/openhab-webui/ (similar to openhab/openhab-webui#537)? |
| @@ -0,0 +1,27 @@ | |||
| /** | |||
| * Copyright (c) 2010-2020 Contributors to the openHAB project | |||
There was a problem hiding this comment.
This looks like an outdated license header (saying 2020 instead of 2021). Does our generator script need an update?
|
@Rosi2143 & @cweitkamp: I didn't follow the process of the ontology expansion in detail, so I wonder if this PR is aligned with #1791, which seems to be the "coordinating issue" for such changes? |
|
I didn't follow #1791 in detail either. Thus I do not know if the list in the OP is fix or final or just an intermediate wrap up. Both properties are not mentioned in the discussion but from my pov the properties (for Point -> Measurements) should be aligned - beside others - with the list of dimensions provided by OHC UoM model. |
cweitkamp
added
the
stale
|
I follow up on it with proposed #1791 |
Rosi2143
deleted the
Rosi2143/Extend_Semantic_with_Distance_and_Angle
branch
Proposal is to add Distance and Angle as additional property
this allows to use these basic units for items.
Signed-off-by: Michael Roßner [email protected]