[automation] Added Actions for Play and Say which sets the volume

[cweitkamp]

• Added Actions for Play and Say which sets the volume

Signed-off-by: Christoph Weitkamp [email protected]

[kaikreuzer]

Hm, I am a bit scared of action proliferation by having dedicated types for every parameter combination.
Can't the volume simply be added as an optional parameter to the existing action types?

[cweitkamp]

In general I tend to agree. Do you know if it will be backwards compatible regarding JSONDB / DTOs? I assume yes, because configuration parameters are a list.

[kaikreuzer]

I'd strongly think so as an optional parameter should not be required and thus it should be fine to not have it in the db for older entries. But it might be safer, if you do a quick test of that assumption.

[cweitkamp]

I will do that. If it is working I will change this PR accordingly. And I will submit a minor patch for openhab/openhab-addons#9145 too.

[cweitkamp]

Works flawlessly. I updated this PR.

[kaikreuzer]

lgtm, thanks!

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/say-action-in-openhab-3-using-js/110345/3

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/say-action-in-openhab-3-using-js/110345/3

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/say-action-in-openhab-3-using-js/110345/3

[frest-de]

I think the Parameter "volume" is not working as it should. Using it with say and googletts in ECMA rules, the volume gets resetted immediately, before the message has finished.

[cweitkamp]

Yes, I agree. It is not working like a user expects. But I am afraid the framework is not able to handle it in a better way. The problem is we are living in an asynchronous world. The VoiceManager stores the current volume, sets the given new, volume, sends the media file or audio stream to be played to the AudioSink and restores the old volume afterwards. Most of the sink implementations send an asynchronous request towards the target device or API and return immediately afterwards. At this time the old volume will already be restored but the actual playback of the media is not finished or even started yet.

https://github.com/openhab/openhab-core/blob/3c301772695b80f5c27a23af987bb2cc440b1387/bundles/org.openhab.core.voice/src/main/java/org/openhab/core/voice/internal/VoiceManagerImpl.java#L229-258