Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discovery] Fixed activation of inbox #1051

Conversation

cweitkamp
Copy link
Contributor

  • Fixed activation of inbox

After #835 and #836 the real "activation" failed because the method was not annotated.

Fixes https://github.com/openhab/openhab2-addons/issues/6144

Signed-off-by: Christoph Weitkamp [email protected]

Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of the Core label Sep 28, 2019
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer
Copy link
Member

Jenkins failed with 2 errors in core.tests, but from the log I couldn't figure out which ones those should be... I suspect some hiccup rather than real failing tests, so let's merge anyway.

@kaikreuzer kaikreuzer merged commit 978be4c into openhab:master Sep 28, 2019
@cweitkamp cweitkamp deleted the bugfix-1048-activation-of-automaticinboxprocessor branch September 28, 2019 20:52
@cweitkamp cweitkamp added this to the 2.5 milestone Sep 28, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hue-auto-discovery-finds-the-same-bridge-all-the-time/39689/7

@cweitkamp cweitkamp changed the title discovery: Fixed activation of inbox [discovery] Fixed activation of inbox Dec 3, 2019
@cweitkamp cweitkamp removed the bug An unexpected problem or unintended behavior of the Core label Dec 3, 2019
Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this pull request Dec 26, 2020
Updated to better reflect usage. Copied some documentation back from orginial ESH description.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Christoph Weitkamp <[email protected]>
GitOrigin-RevId: 978be4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery - duplicated things via search
3 participants