Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some addons restart after uninstalling an unrelated addon #1354

Closed
5iver opened this issue Feb 4, 2020 · 4 comments · Fixed by #1709
Closed

Some addons restart after uninstalling an unrelated addon #1354

5iver opened this issue Feb 4, 2020 · 4 comments · Fixed by #1709
Labels
bug An unexpected problem or unintended behavior of the Core
Milestone
3.0.0.M1

Comments

@5iver
Copy link

5iver commented Feb 4, 2020 •
edited
Loading

I believe this is a symptom of issues reported in the forum, where zigbee or zwave are no longer working after upgrading to 2.5. Logs show cyclic binding uninstalls, which is what I am seeing too. When uninstalling an addon, there are other addons being stopped and started. Included in these are zigbee and zwave. Zigbee does not behave well to binding restarts and usually requires an OH restart to get it working properly. Zwave handles binding restarts OK, but it is a resource hog and responsiveness in the zwave network will be much reduced. If this happens repeatedly, then I can understand why people think 2.5 is broken.

I was recently looking into the new icalendar binding and needed to remove the 1.x caldav-command to test something. I noticed in the log and figured it was time to report this. I suspect that zwave and zigbee are restarting due to org.openhab.core.config.serial being restarted. Here is the log...

2020-02-04 13:11:54.775 [INFO ] [org.apache.sshd.server.session.ServerUserAuthService] - Session openhab@/127.0.0.1:39180 authenticated
2020-02-04 13:23:53.647 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Removing features: openhab-binding-caldav-command1/[1.14.0,1.14.0]
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Changes to perform:
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   Region: root
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     Bundles to uninstall:
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -       org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:55.666 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Stopping bundles:
2020-02-04 13:23:55.666 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zwave/2.5.2.202001250516
2020-02-04 13:23:57.392 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.telegesis/2.5.2.202001250519
2020-02-04 13:23:57.398 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.xbee/2.5.2.202001250519
2020-02-04 13:23:57.406 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.cc2531/2.5.2.202001250518
2020-02-04 13:23:57.411 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.config.serial/2.5.0
2020-02-04 13:23:57.414 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   swagger-jersey2-jaxrs/1.5.8.v20160511-1038
2020-02-04 13:23:57.415 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   reflections/0.9.10.v20160429-1435
2020-02-04 13:23:57.416 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   io.swagger.jaxrs/1.5.8
2020-02-04 13:23:57.417 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122
2020-02-04 13:23:57.421 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.425 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0
2020-02-04 13:23:57.429 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.ember/2.5.2.202001250519
2020-02-04 13:23:57.720 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial/2.5.0
2020-02-04 13:23:57.731 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx/2.5.0
2020-02-04 13:23:57.734 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee/2.5.2.202001250518
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Uninstalling bundles:
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Refreshing bundles:
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     io.swagger.jaxrs/1.5.8 (Wired to reflections/0.9.10.v20160429-1435 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.caldav-command/1.14.0 (Bundle will be uninstalled)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.cc2531/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.ember/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.telegesis/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.xbee/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zwave/2.5.2.202001250516 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.config.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.config.serial/2.5.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)(version>=2.5.0)(!(version>=3.0.0)))"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.io.transport.serial/2.5.0] osgi.wiring.package; filter:="(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     reflections/0.9.10.v20160429-1435 (Should be wired to: com.google.guava/18.0.0 (through osgi.wiring.package; filter:="(osgi.wiring.package=com.google.common.base)"; resolution:="optional"))
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     swagger-jersey2-jaxrs/1.5.8.v20160511-1038 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:58.437 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Done.

2020-02-04 13:23:57.417 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122
2020-02-04 13:23:57.421 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.425 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0
2020-02-04 13:23:57.429 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.ember/2.5.2.202001250519
2020-02-04 13:23:57.720 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial/2.5.0
2020-02-04 13:23:57.731 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx/2.5.0
2020-02-04 13:23:57.734 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee/2.5.2.202001250518
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Uninstalling bundles:
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Refreshing bundles:
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     io.swagger.jaxrs/1.5.8 (Wired to reflections/0.9.10.v20160429-1435 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.caldav-command/1.14.0 (Bundle will be uninstalled)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.cc2531/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.ember/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.telegesis/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.xbee/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zwave/2.5.2.202001250516 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.config.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.config.serial/2.5.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)(version>=2.5.0)(!(version>=3.0.0)))"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.io.transport.serial/2.5.0] osgi.wiring.package; filter:="(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     reflections/0.9.10.v20160429-1435 (Should be wired to: com.google.guava/18.0.0 (through osgi.wiring.package; filter:="(osgi.wiring.package=com.google.common.base)"; resolution:="optional"))
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     swagger-jersey2-jaxrs/1.5.8.v20160511-1038 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:58.437 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Done.
@mhilbush
Copy link
Contributor

mhilbush commented Feb 4, 2020

Interesting, and also possibly the cause of this for bindings that have thing actions.

#1265 (comment)

@splatch
Copy link
Contributor

splatch commented Feb 5, 2020

I believe the root cause is here: #1322 (comment)

Refreshing bundles where we do use declarative services (as far I know) is not needed..

@lolodomo
Copy link
Contributor

lolodomo commented Feb 8, 2020

I think I see the same strange beahviour last week when I uninstalled the Freebox binding, meaning other bindings were restarted. I can't say if all or only a part of the other bindings were restarted.
This is at least a major bug.

@kandersen01
Copy link

It is a major bug, and critical issue imho.

@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Oct 8, 2020
@wborn wborn added this to the 3.0 milestone Oct 8, 2020
wborn added a commit to wborn/openhab-core that referenced this issue Oct 9, 2020
@wborn
Simplify core features to prevent unnecessary bundle refreshes
6329c46 
It seems that when multiple features install the same bundle it may cause Karaf to refresh bundles when (un)installing features.
When the (redundant) openhab-core-automation feature is removed and the serial dependencies are merged into the openhab-transport-serial feature these restarts due these bundle refreshes no longer occur.

Fixes openhab#1322, openhab#1354

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn mentioned this issue Oct 9, 2020
Merged
@wborn wborn linked a pull request Oct 9, 2020 that will close this issue
Simplify core features to prevent unnecessary bundle refreshes #1709
Merged
kaikreuzer pushed a commit that referenced this issue Oct 10, 2020
@wborn
Simplify core features to prevent unnecessary bundle refreshes (#1709)
76f5102 
It seems that when multiple features install the same bundle it may cause Karaf to refresh bundles when (un)installing features.
When the (redundant) openhab-core-automation feature is removed and the serial dependencies are merged into the openhab-transport-serial feature these restarts due these bundle refreshes no longer occur.

Fixes #1322, #1354

Signed-off-by: Wouter Born <[email protected]>
Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this issue Dec 26, 2020
@Confectrician
Secure links should be standard, where available. (openhab#1354)
858701a 
Signed-off-by: Jerome Luckenbach <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@wborn @splatch
Simplify core features to prevent unnecessary bundle refreshes (openh…
cf9795a 
…ab#1709)

It seems that when multiple features install the same bundle it may cause Karaf to refresh bundles when (un)installing features.
When the (redundant) openhab-core-automation feature is removed and the serial dependencies are merged into the openhab-transport-serial feature these restarts due these bundle refreshes no longer occur.

Fixes openhab#1322, openhab#1354

Signed-off-by: Wouter Born <[email protected]>
GitOrigin-RevId: 76f5102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.0.0.M1
Development

Successfully merging a pull request may close this issue.

Simplify core features to prevent unnecessary bundle refreshes wborn/openhab-core
6 participants
@splatch @lolodomo @wborn @mhilbush @5iver @kandersen01