Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[innogysmarthome] Battery state of RST2 is now supported (#8344) #8375

Merged
merged 17 commits into from
Aug 31, 2020
Merged

[innogysmarthome] Battery state of RST2 is now supported (#8344) #8375

merged 17 commits into from
Aug 31, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Aug 31, 2020

RST2 wasn't recognized as battery-powered (in comparision with RST), which caused that no battery warnings were triggered, see issue #8344 . There are a few more optimizations for RST2 with this pull-request.

@Novanic Novanic requested a review from ollie-dev as a code owner August 31, 2020 18:54
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Aug 31, 2020
@cpmeister cpmeister merged commit 8f20990 into openhab:2.5.x Aug 31, 2020
@cpmeister cpmeister added this to the 2.5.9 milestone Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants