-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loxone] fix rollershutter behaviour with alexa integration #8225
Conversation
Signed-off-by: HALLO01 <[email protected]>
eec99fd
to
996c2e2
Compare
Travis tests were successfulHey @HALLO01, |
...ing.loxone/src/main/java/org/openhab/binding/loxone/internal/controls/LxControlJalousie.java
Outdated
Show resolved
Hide resolved
cb034e3
to
f61109e
Compare
update suggested change from Hilbrand Signed-off-by: HALLO01 <[email protected]>
Travis tests were successfulHey @HALLO01, |
1 similar comment
Travis tests were successfulHey @HALLO01, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one comment. I clicked merge and than noticed the sign-off is not valid. You should sign off with your full name and own e-mail address: https://www.openhab.org/docs/developer/contributing.html#sign-your-work I can't fix that now, so please use a valid sign off next time. |
Sorry, didn't know that. |
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]> Signed-off-by: MPH80 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
…8225) Closes openhab#8157 Signed-off-by: HALLO01 <[email protected]>
This PR fixes the bug report #8157