Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loxone] fix rollershutter behaviour with alexa integration #8225

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

HALLO01
Copy link

@HALLO01 HALLO01 commented Jul 29, 2020

This PR fixes the bug report #8157

@HALLO01 HALLO01 requested a review from ppieczul as a code owner July 29, 2020 19:15
@HALLO01 HALLO01 force-pushed the pull-request-loxone branch from eec99fd to 996c2e2 Compare July 29, 2020 19:44
@TravisBuddy
Copy link

Travis tests were successful

Hey @HALLO01,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@HALLO01 HALLO01 force-pushed the pull-request-loxone branch from cb034e3 to f61109e Compare July 30, 2020 19:05
update suggested change from Hilbrand

Signed-off-by: HALLO01 <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @HALLO01,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @HALLO01,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@HALLO01 HALLO01 requested a review from Hilbrand July 30, 2020 19:10
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit d900b26 into openhab:2.5.x Jul 30, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 30, 2020
@Hilbrand
Copy link
Member

Just one comment. I clicked merge and than noticed the sign-off is not valid. You should sign off with your full name and own e-mail address: https://www.openhab.org/docs/developer/contributing.html#sign-your-work I can't fix that now, so please use a valid sign off next time.

@HALLO01
Copy link
Author

HALLO01 commented Jul 31, 2020

Sorry, didn't know that.
Thank you for the hint!

MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants