Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[innogysmarthome] Reconnect fix (#8182) #8186

Merged
merged 13 commits into from
Jul 27, 2020
Merged

[innogysmarthome] Reconnect fix (#8182) #8186

merged 13 commits into from
Jul 27, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jul 24, 2020

Fixes a few reconnect problems regarding the WebSocket, see issue #8182 for more information.

Novanic and others added 13 commits June 10, 2020 19:50
@Novanic
Merge pull request #1 from openhab/2.5.x
78699f9 
Update
@Novanic
Merge pull request #2 from openhab/2.5.x
ae6b891 
Update
@Novanic
Merge pull request #3 from openhab/2.5.x
66abc11 
Update
@Novanic
Merge pull request #4 from openhab/2.5.x
4f2cd51 
Update
@Novanic
Merge pull request #5 from openhab/2.5.x
bd9cfc1 
Update
@Novanic
Merge pull request #6 from openhab/2.5.x
de62002 
Update
@Novanic
Merge pull request #7 from openhab/2.5.x
ad272b7 
Update
@Novanic
Merge pull request #8 from openhab/2.5.x
76c47b8 
Update
@Novanic
Merge pull request #9 from openhab/2.5.x
2ce668b 
Update
@Novanic
Merge pull request #10 from openhab/2.5.x
bcfbee2 
Update
@Novanic
Merge pull request #11 from openhab/2.5.x
2d654b9 
Update
@sstrohschein
Reconnect fix (isDone was never true, because the scheduled task is e…
bc6789c 
…verytime currently running when the scheduleRestartClient method is executed)

Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Reconnect fix (isDone was never true, because the scheduled task is e…
74d7e36 
…verytime currently running when the scheduleRestartClient method is executed)

Signed-off-by: Sven Strohschein <[email protected]>
@Novanic Novanic requested a review from ollie-dev as a code owner July 24, 2020 18:28
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Jul 27, 2020
@Hilbrand Hilbrand merged commit 8f8c0de into openhab:2.5.x Jul 27, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 27, 2020
This was referenced Jul 29, 2020
Closed
Merged
Hilbrand pushed a commit that referenced this pull request Jul 29, 2020
@Novanic
[innogysmarthome] Revert of #8186 (#8224)
f6245f7 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
@Hilbrand Hilbrand removed this from the 2.5.8 milestone Jul 30, 2020
@Novanic Novanic mentioned this pull request Jul 31, 2020
Merged
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
[innogysmarthome] Reconnect fix (openhab#8186)
404a058 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: MPH80 <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
665acb9 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Reconnect fix (openhab#8186)
0fb5b5a 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
f48ef06 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Reconnect fix (openhab#8186)
1886e92 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
8896f2f 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Reconnect fix (openhab#8186)
29fdf14 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
f989bff 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Reconnect fix (openhab#8186)
e3fbc5a 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
f2248d4 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
[innogysmarthome] Reconnect fix (openhab#8186)
22e0326 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
2d96677 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Novanic @CSchlipp
[innogysmarthome] Reconnect fix (openhab#8186)
4862ada 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Novanic @CSchlipp
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
614272f 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
[innogysmarthome] Reconnect fix (openhab#8186)
8336daa 
* Reconnect fix (isDone was never true, because the scheduled task is every time currently running when the scheduleRestartClient method is executed)

Closes openhab#8182 

Signed-off-by: Sven Strohschein <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
[innogysmarthome] Revert of openhab#8186 (openhab#8224)
f867704 
Revert of "Reconnect fix (isDone was never true, because the scheduled task is everytime currently running when the scheduleRestartClient method is executed)" because it causes too many requests when the servers aren't available.

Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@ollie-dev ollie-dev Awaiting requested review from ollie-dev ollie-dev is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Novanic @TravisBuddy @Hilbrand @sstrohschein