Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amazonechocontrol] LoginFix - Enter a valid mail or password #8139

Merged
merged 2 commits into from
Jul 18, 2020
Merged

[amazonechocontrol] LoginFix - Enter a valid mail or password #8139

merged 2 commits into from
Jul 18, 2020

Conversation

Trinitus01
Copy link
Contributor

Fixed: Work around Amazon Security changes and make proxy working again

@Trinitus01 Trinitus01 requested a review from mgeramb as a code owner July 16, 2020 16:57
@TravisBuddy
Copy link

Travis tests were successful

Hey @Trinitus01,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @Trinitus01,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@J-N-K J-N-K added additional testing preferred The change works for the pull request author. A test from someone else is preferred though. bug An unexpected problem or unintended behavior of an add-on labels Jul 16, 2020
@J-N-K J-N-K self-assigned this Jul 16, 2020
@J-N-K J-N-K merged commit 53fe653 into openhab:2.5.x Jul 18, 2020
@J-N-K J-N-K added this to the 2.5.7 milestone Jul 18, 2020
@J-N-K J-N-K removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jul 18, 2020
This was referenced Jul 20, 2020
Closed
Merged
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@Trinitus01 @CSchlipp
[amazonechocontrol] fix login to account (openhab#8139)
042bce2 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Trinitus01 @MPH80
[amazonechocontrol] fix login to account (openhab#8139)
762cf47 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Trinitus01 @andrewfg
[amazonechocontrol] fix login to account (openhab#8139)
f8e7d1a 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Trinitus01 @andrewfg
[amazonechocontrol] fix login to account (openhab#8139)
460fd41 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Trinitus01 @andrewfg
[amazonechocontrol] fix login to account (openhab#8139)
494853c 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Trinitus01 @andrewfg
[amazonechocontrol] fix login to account (openhab#8139)
a2df628 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Trinitus01 @DaanMeijer
[amazonechocontrol] fix login to account (openhab#8139)
1b37390 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Trinitus01 @markus7017
[amazonechocontrol] fix login to account (openhab#8139)
d4c7395 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <[email protected]>
@Trinitus01 Trinitus01 deleted the LoginFix branch February 5, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

Assignees

@J-N-K J-N-K

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Trinitus01 @TravisBuddy @J-N-K