Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] add support for air quality sensor #8125

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Jul 14, 2020

add support for HomeKit accessory "air quality sensor"
Air quality sensor supports following characteristics:

  • general quality indicator (good, bad, etc)
  • Ozone Density
  • Nitrogen Dioxide Density
  • Sulphur Dioxide Density
  • PM2.5 Density
  • PM10 Density
  • VOCDensity

Signed-off-by: Eugen Freiter [email protected]

Eugen Freiter added 2 commits July 14, 2020 13:52
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But you should really try getting around adding @NonNullByDefault to all of the classes. I'm The only reason I'm allowing it for now is because none of the other subclasses have it.

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jul 15, 2020
@cpmeister cpmeister merged commit 60f3c93 into openhab:2.5.x Jul 15, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 15, 2020
@yfre
Copy link
Contributor Author

yfre commented Jul 15, 2020

LGTM. But you should really try getting around adding @NonNullByDefault to all of the classes. I'm The only reason I'm allowing it for now is because none of the other subclasses have it.

@cpmeister thanks. clear. I can take this as the next thing. however, they will not be completely NonNullByDefault as they override some methods from library which is not NonNullByDefault. is there a simple and elegant way to exclude all @OverRide from NonNullByDefault?

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre deleted the air_quality_sensor branch November 15, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants