-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] add support for air quality sensor #8125
Conversation
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But you should really try getting around adding @NonNullByDefault
to all of the classes. I'm The only reason I'm allowing it for now is because none of the other subclasses have it.
@cpmeister thanks. clear. I can take this as the next thing. however, they will not be completely NonNullByDefault as they override some methods from library which is not NonNullByDefault. is there a simple and elegant way to exclude all @OverRide from NonNullByDefault? |
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: MPH80 <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* add air quality sensor * add example to README Signed-off-by: Eugen Freiter <[email protected]>
add support for HomeKit accessory "air quality sensor"
Air quality sensor supports following characteristics:
Signed-off-by: Eugen Freiter [email protected]