Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it is called "Shelly 3EM" not "Shelly EM3" #8119

Merged
merged 1 commit into from
Jul 13, 2020
Merged

it is called "Shelly 3EM" not "Shelly EM3" #8119

merged 1 commit into from
Jul 13, 2020

Conversation

krikk
Copy link
Contributor

@krikk krikk commented Jul 13, 2020

corrected the Product name in the docu, perhaps we should also rename the page name itself...

corrected the Product name in the docu, perhaps we should also rename the page name itself...
@krikk krikk requested a review from markus7017 as a code owner July 13, 2020 16:01
@TravisBuddy
Copy link

Travis tests have failed

Hey @krikk,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Thanks for the contribution!

@cpmeister cpmeister merged commit 1ad2d6a into openhab:2.5.x Jul 13, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 13, 2020
@krikk krikk deleted the patch-1 branch July 15, 2020 07:14
@markus7017
Copy link
Contributor

It's more than the doc, this also affects the thing xml and device discovery. I fixed this in my current code base. You could try with the DEV build.

I close this PR

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...

Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...

Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...

Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
corrected the Product name in the docu, perhaps we should also rename the page name itself...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants