Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VolvoOnCall] Reliable implementation of thing actions #8117

Merged
merged 3 commits into from
Jul 13, 2020
Merged

[VolvoOnCall] Reliable implementation of thing actions #8117

merged 3 commits into from
Jul 13, 2020

Conversation

clinique
Copy link
Contributor

Per Issue #8116

Signed-off-by: clinique [email protected]

@lolodomo lolodomo mentioned this pull request Jul 13, 2020
Closed
19 tasks
@clinique
Misplaced header
74e7647 
Signed-off-by: clinique <[email protected]>
lolodomo
lolodomo requested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your action class must implement your new interface class.

@clinique
Dumb error
3d6796d 
Signed-off-by: clinique <[email protected]>
@openhab openhab deleted a comment from TravisBuddy Jul 13, 2020
@openhab openhab deleted a comment from TravisBuddy Jul 13, 2020
lolodomo
lolodomo approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisBuddy
Copy link

Travis tests were successful

Hey @clinique,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 547bd11 into openhab:2.5.x Jul 13, 2020
@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Jul 13, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 13, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@clinique @CSchlipp
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
06c8732 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
@clinique clinique deleted the Issue_8116 branch July 28, 2020 12:13
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@clinique @MPH80
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
2f0b2c5 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
56526db 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
a4b9901 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
ad9ac9a 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
f21a038 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@clinique @DaanMeijer
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
799b68f 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@clinique @markus7017
[VolvoOnCall] Reliable implementation of thing actions (openhab#8117)
f4a357d 
* Enhancing action method call for Issue openhab#8116

Signed-off-by: clinique <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@clinique @TravisBuddy @cpmeister @lolodomo