Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apache commons and joda time to forbidden packages. #8113

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

Hilbrand
Copy link
Member

No description provided.

@Hilbrand Hilbrand requested a review from cweitkamp July 13, 2020 08:28
@Hilbrand Hilbrand requested a review from a team as a code owner July 13, 2020 08:28
@lolodomo
Copy link
Contributor

What would be the consequence on the existing bindings ? Just new non blocking warnings ?
Because the number of bindings using org.apache.commons.* is very big.

@Hilbrand
Copy link
Member Author

Yes it's a none blocking warning.

@TravisBuddy
Copy link

Travis tests were successful

Hey @Hilbrand,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. I had it on my to-do list too.

@cweitkamp cweitkamp added the infrastructure Build system and Karaf related issues and PRs label Jul 13, 2020
@cweitkamp cweitkamp added this to the 2.5.7 milestone Jul 13, 2020
@cweitkamp cweitkamp merged commit aee9bea into openhab:2.5.x Jul 13, 2020
@Hilbrand Hilbrand deleted the more_forbidden branch July 13, 2020 09:31
cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request Jul 13, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants