[kodi] Thing handler factory with null annotations and constructor injection #8075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jection Signed-off-by: Laurent Garnier <[email protected]>
Travis tests were successfulHey @lolodomo, |
Signed-off-by: Laurent Garnier <[email protected]>
Travis tests were successfulHey @lolodomo, |
cweitkamp
requested changes
Jul 4, 2020
| this.networkAddressService = networkAddressService; | ||
| this.stateDescriptionProvider = stateDescriptionProvider; | ||
| this.webSocketClient = webSocketFactory.getCommonWebSocketClient(); | ||
| } | ||
|
|
||
| @Override | ||
| protected void activate(ComponentContext componentContext) { |
There was a problem hiding this comment.
Please add @Activate annotation here too. Otherwise this method will be ignored in favor of all annotated activation methods.
Another option would be to pass the ComponentContext parameter to the constructor and move all the logic inside this method into the constructor too.
There was a problem hiding this comment.
Excuse me but I have a serious doubt. Please look at the handler factory for the Sonos and LGwebOS bindings for example. They are done like that. If activate method was not called, the LGwebOS binding would just not work at all a(s the WebSocket client would not be started).
There was a problem hiding this comment.
Hm, interesting. I do not have a clue why it is working but it seems to work.
cweitkamp
approved these changes
Jul 5, 2020
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…jection (openhab#8075) * [kodi] Thing handler factory with null annotations and constructor injection Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier [email protected]