Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samsungtv] Partial revert of PR 8025 #8072

Merged
merged 3 commits into from
Jul 12, 2020
Merged

[samsungtv] Partial revert of PR 8025 #8072

merged 3 commits into from
Jul 12, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 4, 2020

Related to #8027

Signed-off-by: Laurent Garnier [email protected]

@lolodomo
[samsungtv] Partial revert of PR 8025
5d2b7d8 
Related to openhab#8027

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo requested a review from paulianttila as a code owner July 4, 2020 14:49
@lolodomo lolodomo mentioned this pull request Jul 4, 2020
Closed
12 tasks
@TravisBuddy
Copy link

Hey @lolodomo,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2bb37090-be07-11ea-a595-8f8781864445

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@kaikreuzer kaikreuzer merged commit 4b81137 into openhab:2.5.x Jul 12, 2020
@lolodomo lolodomo deleted the samsungtv_wsclientstop branch July 13, 2020 05:15
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 13, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[samsungtv] Partial revert of PR 8025 (openhab#8072)
60168e3 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@lolodomo @MPH80
[samsungtv] Partial revert of PR 8025 (openhab#8072)
5137d7b 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[samsungtv] Partial revert of PR 8025 (openhab#8072)
19f83be 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[samsungtv] Partial revert of PR 8025 (openhab#8072)
ff6e05e 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[samsungtv] Partial revert of PR 8025 (openhab#8072)
088cf38 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[samsungtv] Partial revert of PR 8025 (openhab#8072)
1e91d80 
Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[samsungtv] Partial revert of PR 8025 (openhab#8072)
8b30f62 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[samsungtv] Partial revert of PR 8025 (openhab#8072)
9e53909 
Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@lolodomo @TravisBuddy @kaikreuzer @cpmeister