Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] OH3 test compatiblity - NAPresenceCameraHandlerTest uses internal I18nProviderImpl class #7954

Merged
merged 6 commits into from
Jun 20, 2020
Merged

[netatmo] OH3 test compatiblity - NAPresenceCameraHandlerTest uses internal I18nProviderImpl class #7954

merged 6 commits into from
Jun 20, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jun 20, 2020

  • Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
  • New tests added

see issue #7949 for more information

@sstrohschein
[7949] NAPresenceCameraHandlerTest uses internal I18nProviderImpl class
e7505c9 
- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
@Novanic Novanic mentioned this pull request Jun 20, 2020
Closed
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the test label Jun 20, 2020
@cpmeister cpmeister merged commit 033a263 into openhab:2.5.x Jun 20, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 20, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@Novanic @knikhilwiz
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
d561c5c 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@Novanic @CSchlipp
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
415c55d 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
656c6a5 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
5d06ce9 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
520a20a 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
db5ac60 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
32224ad 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
0c7729a 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
[netatmo] NAPresenceCameraHandlerTest uses internal I18nProviderImpl …
5b6168c 
…class (openhab#7954)

- Test-usage of internal classes removed (org.eclipse.smarthome.core.internal) due to OH3 compatibility
- New tests added

Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Novanic @TravisBuddy @cpmeister @sstrohschein