Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dark-sky] Fixed rendering of table in readme #7950

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Conversation

martinvw
Copy link
Member

@martinvw martinvw commented Jun 20, 2020

See also: https://www.openhab.org/addons/bindings/darksky/

Sorry, for the DCO, yes I agree to the DCO

Signed-off-by: Martin van Wingerden [email protected]

@martinvw martinvw requested a review from cweitkamp June 20, 2020 13:28
@TravisBuddy
Copy link

Travis tests were successful

Hey @martinvw,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@martinvw martinvw requested a review from a team June 20, 2020 15:26
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 118a5ce into 2.5.x Jun 20, 2020
@wborn wborn deleted the martinvw-patch-1 branch June 20, 2020 15:31
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 20, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
Signed-off-by: Martin van Wingerden <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Martin van Wingerden <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants