[homekit] fix 100% brightness for dimmer #7932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2020 10:42
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Travis tests were successfulHey @yfre, |
J-N-K
approved these changes
Jun 17, 2020
cpmeister
added
the
bug
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* homekit dimmer. fix 100% brightness Signed-off-by: Eugen Freiter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix for dimmer logic
with PR #7825 a new logic for dimmer handling was introduced.
the new logic suppress either ON state or brightness update depending on the dimmer state and selected dimmer mode. e.g. do not sends "brightness=100%" update on "ON" event. this helps to handle different dimmers behaviours, e.g. soft launch
however, it is not possible anymore to increase brightness to 100%. see https://community.openhab.org/t/homekit-homekit-sending-on-and-100-command/99485/28?u=yfre
This PR adapt logic as follow:
the rule
IF "target state=ON" AND "target brightness=100" THEN do not update brightnessis changed to
IF "target state=ON" AND "target brightness=100" AND "current state = OFF" THEN do not update brightnessthis means, if dimmer is already ON then it is possible to set brightness to 100%
Signed-off-by: Eugen Freiter [email protected]