[insteon] keep track of group state at the device level #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Nielsen <[email protected]>
Travis tests were successfulHey @robnielsen, |
cpmeister
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
This change looks ok to me. But I'll hold off on merging this until after the release goes out, which should be at any moment. If these changes happened to break anything in the binding I'd rather it do so at the beginning of a new release cycle where fixes could be made before the next release.
|
@cpmeister, I've noticed there are still commits for 2.5.6 release. Myself and one other person have been running these changes for about a week. |
|
A week of testing would have been enough time to catch any issues from this PR. So I'll go ahead and merge it. |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
Signed-off-by: Rob Nielsen <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Rob Nielsen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Rob Nielsen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Rob Nielsen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Rob Nielsen <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Rob Nielsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An insteon device has multiple features associated with it and each one potentially had a group state machine. The state machine applies to the device not the feature. This simplifies the design by associating the state machine to the device instead of including on with each feature.