[netatmo] Add support for the Presence camera events - Line-endings fixed

[Novanic]

Just line-endings fixed (changed from CRLF to LF)

And fixed an incompatible API change. There was recently a merge within the netatmo-swagger-decl project which introduced a new required boolean parameter. Actually this parameter isn't required, the default value is declared as "false" within the Netatmo API...

[TravisBuddy]

Travis tests have failed

Hey @Novanic,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests have failed

Hey @Novanic,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cpmeister]

LGTM

[lolodomo]

This is urgent to commit because any PR build in the repo is now failing.

Does it mean the build of the binding could fail again in the future due to a change of API? Are we not depending on a particular version of this external code?

[Novanic]

This is urgent to commit because any PR build in the repo is now failing.

Does it mean the build of the binding could fail again in the future due to a change of API? Are we not depending on a particular version of this external code?

Yes, at least when the change within netatmo-swagger-decl isn't downward compatible. But I hadn't expected that this will appear often because the project isn't very active and the Netatmo API isn't changed often too. But the situation is really bad, the build can break immediately dependent of another project which doesn't know / consider this project...

I think we should do one of the following options:

1. depend on a specific version of the YAML file. This should be easy possible by changing the inputSpec-URL within the pom.xml. So it's under control when to switch to a newer version, the developer has to update the inputSpec-URL when an update should developed.

2. The YAML file could committed within this project. So the dependency to the netatmo-swagger-decl is removed and the build is also running locally without network resources. I don't know if that would a problem with the "license" of the netatmo-swagger-decl project and it's more difficult to get updates from netatmo-swagger-decl.

I would prefer option 1. What do you think?

[Novanic]

This is urgent to commit because any PR build in the repo is now failing.

Does it mean the build of the binding could fail again in the future due to a change of API? Are we not depending on a particular version of this external code?

I have now realized option 1 with this pull-request. The inputSpec points now to a concrete version of the swagger YAML so the build will not "randomly" break again in the future.

Please merge this pull-request soon to fix the build. Thank you and I'm sorry for the problems.

[TravisBuddy]

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[lolodomo]

LGTM