[homematic] Solves stability issues with HmIP devices #7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes #7762 Signed-off-by: Martin Herbst <[email protected]>
Travis tests were successfulHey @MHerbst, |
J-N-K
requested changes
Jun 12, 2020
| return new RpcResponseParser(request).parse(data); | ||
| } catch (UnknownRpcFailureException | UnknownParameterSetException ex) { | ||
| throw ex; | ||
| } catch (Exception ex) { |
There was a problem hiding this comment.
Is it absolutely necessary to catch Exception here?
| */ | ||
| private synchronized Object[] sendMessage(int port, RpcRequest<String> request, int rpcRetryCounter) | ||
| throws IOException { | ||
| private byte[] send(int port, RpcRequest<String> request) throws Exception { |
There was a problem hiding this comment.
Please do not throw Exception, either define your own like HomematicException extends Exception or use something like IllegalStateException (or what fits best) and catch only that one. The problem with catchin Exception is that it hides programming errors like NPE.
There was a problem hiding this comment.
I agree with you regarding the catching and throwing of "Exception", but I tried to stay close to the original implementation and Jetty throws a lot of different exceptions. Will try to get rid of the Exception.
Signed-off-by: Martin Herbst <[email protected]>
Travis tests were successfulHey @MHerbst, |
J-N-K
reviewed
Jun 12, 2020
| } else { | ||
| logger.warn("Non-blocking XmlRpcRequest failed, status code: {} / request: {}", httpStatus, | ||
| request); | ||
| resp.abort(new Exception()); |
There was a problem hiding this comment.
Suggested change
| resp.abort(new Exception()); | |
| resp.abort(new IOException()); |
Signed-off-by: Martin Herbst <[email protected]>
Travis tests were successfulHey @MHerbst, |
J-N-K
approved these changes
Jun 12, 2020
cpmeister
added
the
bug
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* Solves stability issues with HmIP devices The CCU gets unresponsive if several HmIP devices are installed and always "non-blocking" requests are used. By reducing the use to what is absolutely necessary, the problem can be avoide. Fixes openhab#7762 Signed-off-by: Martin Herbst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCU gets unresponsive if several HmIP devices are installed and
always "non-blocking" requests are used. By reducing the use to what is
absolutely necessary, the problem can be avoided.
Fixes #7762
Signed-off-by: Martin Herbst [email protected]