-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[astro] Method renamed (relative to TimeZoneProvider) #7877
Conversation
ec31191
to
21d3d99
Compare
Signed-off-by: Laurent Garnier <[email protected]>
21d3d99
to
392376c
Compare
Travis tests have failedHey @lolodomo, |
1 similar comment
Travis tests have failedHey @lolodomo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any idea what broke the unit tests? |
To be honest, there is a very high probably that I broke the integration tests with my PR #7852 . |
Signed-off-by: Laurent Garnier <[email protected]>
Integration tests are now fixed. I confirmed the problem was due to the changes in a previous PR, not this one. |
Travis tests were successfulHey @lolodomo, |
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* [astro] Method renamed (relative to TimeZoneProvider) * Fix the integration tests broken by a previous PR Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier [email protected]