Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro] Method renamed (relative to TimeZoneProvider) #7877

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jun 8, 2020

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from gerrieg as a code owner June 8, 2020 16:22
@lolodomo lolodomo force-pushed the astro_timezoneprovider branch from ec31191 to 21d3d99 Compare June 9, 2020 07:10
@lolodomo lolodomo force-pushed the astro_timezoneprovider branch from 21d3d99 to 392376c Compare June 9, 2020 07:15
@lolodomo lolodomo changed the title [astro] Parameter renamed (relative to timezone) [astro] Method renamed (relative to TimeZoneProvider) Jun 9, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

1 similar comment
@TravisBuddy
Copy link

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Any idea what broke the unit tests?

@lolodomo
Copy link
Contributor Author

lolodomo commented Jun 9, 2020

To be honest, there is a very high probably that I broke the integration tests with my PR #7852 .
I can try to fix them in this PR. I have in my local branch errors too.

@lolodomo
Copy link
Contributor Author

lolodomo commented Jun 9, 2020

Integration tests are now fixed. I confirmed the problem was due to the changes in a previous PR, not this one.

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister merged commit 67b11c0 into openhab:2.5.x Jun 9, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 9, 2020
@lolodomo lolodomo deleted the astro_timezoneprovider branch June 9, 2020 20:48
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
* [astro] Method renamed (relative to TimeZoneProvider)
* Fix the integration tests broken by a previous PR

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants