Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xmppclient] fix typo in doc example #7866

Merged
merged 1 commit into from
Jun 6, 2020
Merged

[xmppclient] fix typo in doc example #7866

merged 1 commit into from
Jun 6, 2020

Conversation

TRSx80
Copy link

@TRSx80 TRSx80 commented Jun 6, 2020

If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."

If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
@TRSx80 TRSx80 requested a review from pavel-gololobov as a code owner June 6, 2020 02:14
@TravisBuddy
Copy link

Travis tests were successful

Hey @TRSx80,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cpmeister cpmeister merged commit 4ed1124 into openhab:2.5.x Jun 6, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 6, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."

Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."

Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
If Bridge example at top uses (two) ## then split command further down needs to, also.

I was trying to get this working on my own machine but could not until making that small change. So in that sense, it has been (lightly) "tested."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants