[telegram] allow access restrictions on chat ids #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <[email protected]>
ZzetT
reviewed
Jun 5, 2020
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Outdated
Show resolved
Hide resolved
ZzetT
reviewed
Jun 5, 2020
Signed-off-by: Jan N. Klug <[email protected]>
ZzetT
approved these changes
Jun 5, 2020
cweitkamp
requested changes
Jun 6, 2020
| chatIds.add(Long.valueOf(chatIdStr)); | ||
| if (chatIdStr.trim().startsWith("<")) { | ||
| // inbound only | ||
| authorizedSenderChatId.add(Long.valueOf(chatIdStr.substring(1))); |
There was a problem hiding this comment.
If you trim() earlier it is not a good idea to use substring(1) on the not trimmed String. Maybe introduced a local variable for the `trimmedChatId and use it here and in the following lines.
Signed-off-by: Jan N. Klug <[email protected]>
Travis tests were successfulHey @J-N-K, |
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* allow access restrictions on chat ids Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use access modifiers on chat is. Use-case: Some chat ids (e.g. children) should receive notifications but should not be allowed to send commands.
Fully backward compatible, no modifier = sending and receiving
Signed-off-by: Jan N. Klug [email protected]