Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deconz] Add support for ZHAThermostat #7828

Merged
merged 8 commits into from
Jun 7, 2020
Merged

[deconz] Add support for ZHAThermostat #7828

merged 8 commits into from
Jun 7, 2020

Conversation

LukasA83
Copy link
Contributor

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes #6251

Signed-off-by: Lukas Agethen [email protected]

LukasA83 added 3 commits May 31, 2020 23:29
@LukasA83
[deconz] Add support for ZHAThermostat
64c83c0 
Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes #6251

Signed-off-by: Lukas Agethen <[email protected]>
@LukasA83
[deconz] Add support for ZHAThermostat
32b52ed 
Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes #6251

Signed-off-by: Lukas Agethen <[email protected]>
@LukasA83
Merge branch 'deconz' of https://github.com/LukasA83/openhab-addons.git…
163360f 
… into HEAD
@LukasA83 LukasA83 requested a review from davidgraeff as a code owner May 31, 2020 21:46
@TravisBuddy
Copy link

Travis tests were successful

Hey @LukasA83,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K
J-N-K requested changes Jun 1, 2020
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please also apply spotless formatter.

.../src/main/java/org/openhab/binding/deconz/internal/handler/SensorThermostatThingHandler.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/deconz/internal/handler/SensorThermostatThingHandler.java Outdated Show resolved Hide resolved
.../src/main/java/org/openhab/binding/deconz/internal/handler/SensorThermostatThingHandler.java Outdated Show resolved Hide resolved
...deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java Outdated Show resolved Hide resolved
...deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java Show resolved Hide resolved
bundles/org.openhab.binding.deconz/src/main/resources/ESH-INF/thing/sensor-thing-types.xml Show resolved Hide resolved
@J-N-K J-N-K self-assigned this Jun 1, 2020
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jun 1, 2020
@LukasA83
Clean-up
c852d95 
Signed-off-by: Lukas Agethen <[email protected]>
@TravisBuddy
Copy link

Travis tests have failed

Hey @LukasA83,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@TravisBuddy
Copy link

Travis tests were successful

Hey @LukasA83,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @LukasA83,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@LukasA83 LukasA83 requested a review from J-N-K June 4, 2020 16:39
DerOetzi
DerOetzi requested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@DerOetzi DerOetzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looking forward for the support of thermostat, so I can integrate my pending 2 heatings as well, for having reached my AVM limit of 12 thermostats.

There is one point, which is in my opinion a wrong inheritance direction.

...enhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/dto/SensorConfig.java Outdated Show resolved Hide resolved
@LukasA83
Minor refactoring
88dd157 
Signed-off-by: Lukas Agethen <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @LukasA83,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @LukasA83,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@LukasA83
Copy link
Contributor Author

LukasA83 commented Jun 7, 2020

I see Jenkins did not run for the latest commit. Is there anything wrong?

cpmeister
cpmeister approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit f9e5454 into openhab:2.5.x Jun 7, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 7, 2020
@J-N-K J-N-K mentioned this pull request Jun 22, 2020
Closed
@J-N-K J-N-K mentioned this pull request Jun 24, 2020
Merged
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@LukasA83 @CSchlipp
[deconz] Add support for ZHAThermostat (openhab#7828)
f654a31 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@LukasA83 @andrewfg
[deconz] Add support for ZHAThermostat (openhab#7828)
98eb49c 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@LukasA83 @andrewfg
[deconz] Add support for ZHAThermostat (openhab#7828)
c73451f 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@LukasA83 @andrewfg
[deconz] Add support for ZHAThermostat (openhab#7828)
aaa3e3d 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@LukasA83 @andrewfg
[deconz] Add support for ZHAThermostat (openhab#7828)
718e824 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@LukasA83 @DaanMeijer
[deconz] Add support for ZHAThermostat (openhab#7828)
635b389 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@LukasA83 @markus7017
[deconz] Add support for ZHAThermostat (openhab#7828)
15e6821 
* [deconz] Add support for ZHAThermostat

Adds support for Zigbee Thermostat based on Eurotronics Spirit
Closes openhab#6251

Signed-off-by: Lukas Agethen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerOetzi DerOetzi DerOetzi requested changes

@J-N-K J-N-K J-N-K approved these changes

@cpmeister cpmeister cpmeister approved these changes

@davidgraeff davidgraeff Awaiting requested review from davidgraeff davidgraeff is a code owner

Assignees

@J-N-K J-N-K

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.

[deconz] support thing type ZHAThermostat (e.g. Eurotronic SPIRIT / SPZB0001)
5 participants
@LukasA83 @TravisBuddy @cpmeister @DerOetzi @J-N-K