Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgwebos] Mask access key #7771

Merged
merged 2 commits into from
May 26, 2020
Merged

[lgwebos] Mask access key #7771

merged 2 commits into from
May 26, 2020

Conversation

lolodomo
Copy link
Contributor

Fix #7758

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label May 24, 2020
@lolodomo lolodomo requested a review from sprehn as a code owner May 24, 2020 12:15
@lolodomo
Copy link
Contributor Author

This first part allows not logging the access key when contained in the exchanged messages.

Just remains to decide if we set the configuration setting as "password" or not.

@lolodomo lolodomo force-pushed the lgwebos_masktoken branch from 36eea19 to 982c68c Compare May 24, 2020 12:30
@openhab openhab deleted a comment from TravisBuddy May 24, 2020
@lolodomo lolodomo force-pushed the lgwebos_masktoken branch 2 times, most recently from d5f927b to 8b205ff Compare May 24, 2020 13:03
@openhab openhab deleted a comment from TravisBuddy May 24, 2020
@lolodomo
[lgwebos] Mask access key
7c4b814 
Fix openhab#7758

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the lgwebos_masktoken branch from 8b205ff to 7c4b814 Compare May 24, 2020 13:19
@openhab openhab deleted a comment from TravisBuddy May 24, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@openhab openhab deleted a comment from TravisBuddy May 24, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo lolodomo force-pushed the lgwebos_masktoken branch from afd533d to 94175c6 Compare May 25, 2020 11:55
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label May 25, 2020
@lolodomo lolodomo changed the title [WIP][lgwebos] Mask access key [lgwebos] Mask access key May 25, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@J-N-K J-N-K merged commit 1594a25 into openhab:2.5.x May 26, 2020
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label May 26, 2020
@J-N-K J-N-K added this to the 2.5.6 milestone May 26, 2020
@lolodomo lolodomo deleted the lgwebos_masktoken branch May 26, 2020 18:43
@lolodomo lolodomo mentioned this pull request May 27, 2020
Merged
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[lgwebos] Mask access key (openhab#7771)
7c8553a 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[lgwebos] Mask access key (openhab#7771)
593c32d 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[lgwebos] Mask access key (openhab#7771)
c56fbdd 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Mask access key (openhab#7771)
037e291 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Mask access key (openhab#7771)
d10c916 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Mask access key (openhab#7771)
38ee967 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Mask access key (openhab#7771)
88a9e88 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[lgwebos] Mask access key (openhab#7771)
2c40ab8 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[lgwebos] Mask access key (openhab#7771)
69221c6 
Fix openhab#7758

* [lgwebos] Mask access key
* Mark the access key as a password in the thing configuration

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@sprehn sprehn Awaiting requested review from sprehn sprehn is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.

[lgwebos] Access key
3 participants
@lolodomo @TravisBuddy @J-N-K