[freebox] Hot fix for login to the freebox

[lolodomo]

PR #7460 broke the freebox binding

Signed-off-by: Laurent Garnier [email protected]

[cpmeister]

Could you add a unit test to this as well? I'd like to prevent any future mishaps.

[lolodomo]

I don't know where @cweitkamp put his unit test.
We cannot wait too much, the binding is just unusable until this patch is applied for any user that has migrated to OH 2.5.5 !

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cweitkamp]

See #7460 (comment).

[lolodomo]

I will not take a long time to introduce all the testing stuff to the binding (I am not enough familiar with that) even more when the bug was not introduced by me,
The priority is to provide a fix to end users as fast as possible.

[cpmeister]

Just add this file and fill in the blanks:
src/test/java/org/openhab/binding/freebox/internal/api/FreeboxApiManagerTest

package org.openhab.binding.freebox.internal.api;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.Assert;
import org.junit.Test;

@NonNullByDefault
public class FreeboxApiManagerTest{

    @Test
    public void hmacSha1Test() throws Exception {
        String expected = "_______";
        String actual = FreeboxApiManager.hmacSha1("_______", "_______");
        Assert.assertEquals(expected, actual);
    }

}

You will need to make FreeboxApiManager.hmacSha1 public to make this work.
Any of the classes you need to import should be

[lolodomo]

Thank you for the help, I did not imagine it was just one class to add.

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cpmeister]

Some of our build tools don't like EOF without a newline. So add a newline here.

[cpmeister]

Thank you for the help, I did not imagine it was just one class to add.

Unit testing with JUnit is made to be as simple as possible with the idea that the easier it is the more likely unit tests would be written. More tests means more stable code, so it is a win-win for developers.

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.