[hue] Improved code (notify status listener) #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <[email protected]>
cpmeister
requested changes
May 1, 2020
|
|
||
| private static final String DEVICE_TYPE = "EclipseSmartHome"; | ||
|
|
||
| private static enum STATUS_TYPE { |
There was a problem hiding this comment.
Please change enum name to camelcase
There was a problem hiding this comment.
You're right. It is fixed.
Signed-off-by: Laurent Garnier <[email protected]>
|
If you could merge this one, I will then update my PR about the hue groups because this will introduce a confliuct. |
cweitkamp
requested changes
May 2, 2020
| private long sensorPollingInterval = TimeUnit.MILLISECONDS.toMillis(500); | ||
| public static final Set<ThingTypeUID> SUPPORTED_THING_TYPES = Collections.singleton(THING_TYPE_BRIDGE); | ||
|
|
||
| private static final String DEVICE_TYPE = "EclipseSmartHome"; |
There was a problem hiding this comment.
I think it is time to change this to "openHAB".
cweitkamp
approved these changes
May 2, 2020
MrRonfo
pushed a commit
to MrRonfo/openhab-addons
that referenced
this pull request
May 25, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Fabio Possieri <[email protected]>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [hue] Improved code (notify status listener) Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier [email protected]