[ecobee] Improve handling of access token expiration #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <[email protected]>
Travis tests were successfulHey @mhilbush, |
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
Signed-off-by: Mark Hilbush <[email protected]>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
Signed-off-by: Mark Hilbush <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Signed-off-by: Mark Hilbush <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Mark Hilbush <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Mark Hilbush <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Mark Hilbush <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Mark Hilbush <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Mark Hilbush <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Mark Hilbush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been cases where the call to the Ecobee API has resulted in a response indicating that the token has expired. It happens very rarely, typically once every 2-4 weeks. Generally, this should not happen, since the OAuthClientService in OHC uses an expire time buffer (default is 10 seconds) to refresh the token before it expires.
I wanted to change the expire time buffer to a longer amount, but the API currently doesn't support that. See here.
Therefore, in this PR, the binding will check for expiration using a custom expire time buffer (using
AccessTokenResponse.isExpired(), then refresh the access token ifisExpired()returns true.Also, the access token expired response from the Ecobee API will be handled less harshly.
Signed-off-by: Mark Hilbush [email protected]